Trim whitespaces from org names when an org is created or saved #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevkevinpal
approved these changes
Feb 22, 2024
Comment on lines
+89
to
+102
| t.Run("should return error if org name contains only spaces", func(t *testing.T) { | ||
| rr := httptest.NewRecorder() | ||
| handler := http.HandlerFunc(oHandler.CreateOrEditOrganization) | ||
|
|
||
| invalidJson := []byte(`{"name": " "}`) | ||
| req, err := http.NewRequestWithContext(ctx, http.MethodPost, "/", bytes.NewReader(invalidJson)) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
|
|
||
| handler.ServeHTTP(rr, req) | ||
|
|
||
| assert.Equal(t, http.StatusBadRequest, rr.Code) | ||
| }) |
There was a problem hiding this comment.
lets add another test to create a name that looks like " Abdul " and assert it gets added as "Abdul"
There was a problem hiding this comment.
@kevkevinpal Added #1553
|
I added an extra 20k sats for the other test abdul. I'll pay out when I get funds. |
|
Paid 170k sats! https://community.sphinx.chat/bounty/1559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
https://www.loom.com/share/149dc5a443dd463eb5dacc8c4f4bbf9f
Issue ticket number and link
Closes #1548
Type of change
Please delete options that are not relevant.
Checklist before requesting a review